Windows problems with 3.4.2

Discussion:

Neil Hodgson

2014-05-25 00:27:45 UTC

There have been some reported problems at shutdown with SciTE on Windows. This could be caused by changes to make Scintilla clean up more thoroughly on exit.

https://sourceforge.net/p/scintilla/bugs/1602/
https://sourceforge.net/p/scintilla/bugs/1603/

With 3.4.2, Scintilla on Windows frees system graphics factory objects and DLLs which were not freed in 3.4.1. This was done to make it easier to examine the resources still in use at termination to see if there are any leaks.

An error message appears when freeing the DirectDraw factory object: "The release of the last IDXGIFactory object should not be called from DllMain". However, on my machine there are no consequences from this - SciTE may be in memory for a second or two extra but it does exit and there is no crash dialog.

This problem should only be with the DLL form of native Windows builds. It should not affect Qt on Windows, or where Scintilla is statically linked to the application. It should only occur when DirectDraw is used (technology=1).

Change sets for the resource clean ups:
https://sourceforge.net/p/scintilla/code/ci/7484826e3e0ad2303fb7ddfecf45f9748cef97dc/
https://sourceforge.net/p/scintilla/code/ci/abf434dfaf51d0552d195aa7e14945c8402c9181/

Neil

--
You received this message because you are subscribed to the Google Groups "scintilla-interest" group.
To unsubscribe from this group and stop receiving emails from it, send an email to scintilla-interest+***@googlegroups.com.
To post to this group, send email to scintilla-***@googlegroups.com.
Visit this group at http://groups.google.com/group/scintilla-interest.
For more options, visit https://groups.google.com/d/optout.

Neil Hodgson

2014-05-26 02:25:30 UTC

Permalink

The repositories have been branched to make a fix release 3.4.3 using the branch name 343-Win32-Fix. These branches start at release 3.4.2 and only change the code for termination on Windows. They do not include any other changes made since 3.4.2 such as the removal of style byte indicators. Once 3.4.3 is released and survived a few days, this branch will be merged back into default.

Tentative downloads are available from scintilla.org:
http://www.scintilla.org/scite343.zip Source
http://www.scintilla.org/wscite343.zip Windows executable
These may not be final if the changes do not fix all the problems.

Neil

--
You received this message because you are subscribed to the Google Groups "scite-interest" group.
To unsubscribe from this group and stop receiving emails from it, send an email to scite-interest+***@googlegroups.com.
To post to this group, send email to scite-***@googlegroups.com.
Visit this group at http://groups.google.com/group/scite-interest.
For more options, visit https://groups.google.com/d/optout.

Gianfranco

2014-05-26 08:04:00 UTC

Permalink

Post by Neil Hodgson
http://www.scintilla.org/scite343.zip Source
http://www.scintilla.org/wscite343.zip Windows executable
These may not be final if the changes do not fix all the problems.

This release works for me (Windows 7 PRO SP1 64bit).
I solved this problem on the 3.4.2 setting the technology property back to
0.

Tanks,
Gianfranco

Neil Hodgson

2014-05-31 05:35:40 UTC

Permalink

Post by Neil Hodgson
Once 3.4.3 is released and survived a few days, this branch will be merged back into default.

The 343-Win32-Fix branch has been merged back into default. The default branch now has both the changes made to fix the crashes and hangs on Windows as well as the changes made on the default branch before then including elimination of style byte indicators. There have been some minor changes since then to make files and fix some minor issues.

Since this is the first time I have used branching in this way, I may have done something wrong, so those who contributed recently merged changes should check the current code in the repository is working as expected.

Neil