Fortran code folding

[Kyle Horne]

Hi all,

I have an updated version of LexFortran.cxx that correctly handles the new
abstract types and interfaces from the 2003 standard. I have tested it
through geany, and it seems to correct the problem of folding an abstract
type or interface folding the remainder of the document instead of just the
block. The new version is attached to this message.

[Neil Hodgson]

I have an updated version of LexFortran.cxx that correctly handles the new abstract types and interfaces from the 2003 standard.

This change has no effect since the previous line accepts any occurrence of the “interface” keyword:
|| strcmp(s, "function") == 0 || strcmp(s, "interface") == 0

The Fortran folder has some quite bad problems including writing outside of allocated memory for ‘do <label>’ loops, potentially crashing. The labels used for do loops are tracked in the *static* doLabels array using the posLabel index. Since these variables are static, they are shared between all loaded Fortran documents so one document may interfere with another. The life of the array elements is also a mess: if the ‘do’ and the label are far enough apart so that the label is off-screen and its folding not updated with the ‘do’ line then all changes to the ‘do’ line will increment posLabel, eventually overflowing doLabels.

Neil

[Neil Hodgson]

The Fortran folder has some quite bad problems including writing outside of allocated memory for 'do <label>' loops, potentially crashing.

Fixing this properly is complex, requiring a memory of the do-label loops that are active. This would be best done by converting the Fortran lexer to an object lexer but that would require more effort. It might be possible to use the per-line state for this but, again, this is tricky.

The easiest approach to fixing the bug will be to remove all folding of do-label loops. If no one else wants to work on Fortran folding, I will remove this code soon.

Neil

[Neil Hodgson]

Fortran do-label folding has been removed with this commit:
https://sourceforge.net/p/scintilla/code/ci/02c8d916484f8026f69daf2232315d9dc5ae78bc/

Neil